Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Rename and move memory profiler info under ti.profiler #4227

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

mzmzm
Copy link
Contributor

@mzmzm mzmzm commented Feb 8, 2022

Related issue = #3782

@netlify
Copy link

netlify bot commented Feb 8, 2022

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: a34e89e

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/6201e5c062b534000717f667

😎 Browse the preview: https://deploy-preview-4227--docsite-preview.netlify.app

@mzmzm mzmzm changed the title commit [Refactor] Rename and move memory profiler info under ti.profiler Feb 8, 2022
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would like to unify the name :-)

python/taichi/profiler/memory_profiler.py Outdated Show resolved Hide resolved
python/taichi/__init__.py Outdated Show resolved Hide resolved
@mzmzm mzmzm requested a review from strongoier February 8, 2022 03:40
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strongoier strongoier merged commit 118b278 into taichi-dev:master Feb 8, 2022
@mzmzm mzmzm deleted the rename_and_move_memory_profiler branch February 8, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants