Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Remove global instance of DecoratorRecorder #4254

Merged
merged 3 commits into from
Feb 14, 2022

Conversation

PGZXB
Copy link
Contributor

@PGZXB PGZXB commented Feb 10, 2022

Related issue = #2768

Move DecoratorRecorder into ASTBuilder -> Use member of ASTBuilder instead of global instance
Renaming : DecoratorRecorder -> ForLoopDecoratorRecorder

@netlify
Copy link

netlify bot commented Feb 10, 2022

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: 02d0db9

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/6209d79b1c65a2000859cecb

😎 Browse the preview: https://deploy-preview-4254--docsite-preview.netlify.app

@PGZXB PGZXB changed the title Remove global instance of DecoratorRecorder [refactor] Remove global instance of DecoratorRecorder Feb 10, 2022
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strongoier strongoier merged commit b303a52 into taichi-dev:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants