[Bug] Only ban passing non contiguous torch tensors to taichi kernels. #4258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to @ifsheldon for reporting the bug! It's too strict to ban all view tensors as Pytorch view tensor return itself as a new view Tensor when nothing changes. So what we really wanted to ban was actually non contiguous tensors. ``` In [2]: a = torch.ones(4, 4) In [4]: b = a.view(4, 4) In [6]: b._is_view() Out[6]: True In [7]: b.is_contiguous() Out[7]: True In [8]: a._is_view() Out[8]: False ``` FYI in `from_torch` we actually explicitly call `tensor.contiguous()` to make sure it's valid. For ndarrays we want users to do that explicitly so that they're aware of the memcpy.
|
✔️ Deploy Preview for docsite-preview ready! 🔨 Explore the source changes: 9de8ab3 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/620513ed770bdf00075c19ec 😎 Browse the preview: https://deploy-preview-4258--docsite-preview.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @ifsheldon for reporting the bug!
It's too strict to ban all view tensors as Pytorch view tensor return
itself as a new view Tensor when nothing changes.
So what we really wanted to ban was actually non contiguous tensors.
FYI in
from_torchwe actually explicitly calltensor.contiguous()tomake sure it's valid. For ndarrays we want users to do that explicitly
so that they're aware of the memcpy.
Related issue = #