-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] Make Expr constrctor explicit #4272
Conversation
✔️ Deploy Preview for docsite-preview canceled. 🔨 Explore the source changes: 158d876 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/620c70bb377fc300089f06c9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Hmm, I believe this would break the build. Could you help take a look? https://github.com/taichi-dev/taichi/runs/5181090562?check_suite_focus=true |
okay,I'll check and fix this~ |
f437242
to
e29b006
Compare
I may have fixed the build error~ |
It seems there is still a tiny issue left, maybe a header that is not included? |
Related issue = #4271