-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opengl] Use element shape as compile information for OpenGL backend #4284
Conversation
✔️ Deploy Preview for docsite-preview ready! 🔨 Explore the source changes: 3b8eca1 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/62138e2714a72c0008e8a390 😎 Browse the preview: https://deploy-preview-4284--docsite-preview.netlify.app |
/format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Only had a few nits and then it's good to go! :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Related issue = #3903
Motivation:
Taichi automatically re-compiles the kernel when element shapes change. Therefore, element shape is compile-time static. This PR embed the element shape information into shader code for OpenGL backend.
Briefings:
ExternalTensorExpression
andExternalPtrStmt
to get layout and element shape information.