Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] Hide internal apis about Fields #4302

Merged
merged 25 commits into from
Feb 17, 2022

Conversation

mzmzm
Copy link
Contributor

@mzmzm mzmzm commented Feb 16, 2022

Related issue = #3782

@netlify
Copy link

netlify bot commented Feb 16, 2022

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: f282e0d

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/620e6a9092380e0007a352d6

😎 Browse the preview: https://deploy-preview-4302--docsite-preview.netlify.app

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to cancel modifications to loop_range, otherwise it will conflict with #4303.

@mzmzm
Copy link
Contributor Author

mzmzm commented Feb 16, 2022

You may need to cancel modifications to loop_range, otherwise it will conflict with #4303.

Done

python/taichi/lang/struct.py Outdated Show resolved Hide resolved
tests/python/test_struct_for_intermediate.py Outdated Show resolved Hide resolved
python/taichi/lang/field.py Outdated Show resolved Hide resolved
python/taichi/lang/matrix.py Outdated Show resolved Hide resolved
python/taichi/lang/field.py Outdated Show resolved Hide resolved
python/taichi/lang/field.py Outdated Show resolved Hide resolved
@mzmzm
Copy link
Contributor Author

mzmzm commented Feb 17, 2022

/format

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strongoier strongoier merged commit d7853fe into taichi-dev:master Feb 17, 2022
Lang Features & Python automation moved this from To do to Done Feb 17, 2022
Tiny-Box pushed a commit to Tiny-Box/taichi that referenced this pull request Feb 21, 2022
* commit

* fix

* cancel loop_range

* fix test

* fix test

* Update struct.py

* restore _parent

* fix

* fix test

* fix test

* fix test

* fix aot test

* fix

* fix snode

* Update snode.py

* move parent and snode

* Update misc.py

* Update field.py

* Auto Format

Co-authored-by: Taichi Gardener <taichigardener@gmail.com>
@mzmzm mzmzm deleted the apt_clean_field branch March 8, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants