[gui] [refactor] Avoid exposing different APIs with different GGUI_AVAILABLE values #4329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for docsite-preview ready! 🔨 Explore the source changes: 8adbc0d 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/620f6860e8f93600084b39db 😎 Browse the preview: https://deploy-preview-4329--docsite-preview.netlify.app |
|
/format |
Tiny-Box
pushed a commit
to Tiny-Box/taichi
that referenced
this pull request
Feb 21, 2022
…AILABLE values (taichi-dev#4329) * [gui] [refactor] Avoid exposing different APIs depending on GGUI_AVAILABLE * Make pylint happy * Fix * Auto Format Co-authored-by: Taichi Gardener <taichigardener@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #3782
This PR replaces inheritance with composition to avoid inheriting from a class only available when GGUI is available. Now APIs exposed from the
uisubpackage will not depend on whetherGGUI_AVAILABLE=True. Meanwhile, the error checking for using GGUI whenGGUI_AVAILABLE=Falseremains the same.