Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix generate_example_videos.py #4347

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

ailzhang
Copy link
Contributor

generate_example_videos.py doesn't throw when the subprocess fails. This PR fixes it.

Related issue = #

`generate_example_videos.py` doesn't throw when the subprocess fails. This PR fixes it.
@netlify
Copy link

netlify bot commented Feb 21, 2022

✔️ Deploy Preview for docsite-preview canceled.

🔨 Explore the source changes: ca76ebb

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/62130a6721b50500086b0eb6

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang ailzhang merged commit 2a71258 into taichi-dev:master Feb 21, 2022
@ailzhang ailzhang deleted the fix_generate_example_videos branch February 21, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants