Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Refactor llvm-offloaded-task-name mangling #4418

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

PGZXB
Copy link
Contributor

@PGZXB PGZXB commented Mar 1, 2022

Related issue = #4401

Before: {kernel_name}_{global_counter}_{task_name}{suffix} -> Now: {kernel_name}_{counter_per_kernel}_{task_name}{suffix}

Cascade: ndarry_writer & ndarray_reader 's name should be mangled
Note: Because of async_mode, counter_per_kernel: std::atomic

@netlify
Copy link

netlify bot commented Mar 1, 2022

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: 78e11c8

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/621dbab8db93fb00074885c5

😎 Browse the preview: https://deploy-preview-4418--docsite-preview.netlify.app

@PGZXB PGZXB requested a review from strongoier March 1, 2022 07:23
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strongoier strongoier merged commit 1a8ec6e into taichi-dev:master Mar 2, 2022
@PGZXB PGZXB deleted the dev-refactor-lotn-mangling branch October 8, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants