Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Remove Expression::serialize and add ExpressionHumanFriendlyPrinter #4657

Merged
merged 1 commit into from
Apr 2, 2022
Merged

[refactor] Remove Expression::serialize and add ExpressionHumanFriendlyPrinter #4657

merged 1 commit into from
Apr 2, 2022

Conversation

PGZXB
Copy link
Contributor

@PGZXB PGZXB commented Mar 29, 2022 •
edited
Loading

Related issue = #

At present, Expression::serialize is only for generating human-friendly string.

  1. Remove Expression::serialize and add ExpressionHumanFriendlyPrinter
  2. Prepare for adding OfflineCacheKeyGenerator instead of using IRPrinter to generate cache key

@netlify
Copy link

netlify bot commented Mar 29, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 2a84d1a
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6242e32cd9c15e00081dc5dd
😎 Deploy Preview https://deploy-preview-4657--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PGZXB PGZXB requested a review from strongoier March 29, 2022 12:01
strongoier
strongoier approved these changes Apr 2, 2022
View reviewed changes
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@strongoier strongoier merged commit 32c7140 into taichi-dev:master Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongoier strongoier strongoier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PGZXB @strongoier