Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIMT] [cuda] Use correct source lane offset for warp intrinsics #4734

Merged
merged 3 commits into from
Apr 8, 2022

Conversation

qiao-bo
Copy link
Collaborator

@qiao-bo qiao-bo commented Apr 7, 2022

Related issue = #4631

For warp size of 32, correct lane offset is 0 for shfl_up* and 31 for shfl_down*.
ref https://docs.nvidia.com/cuda/parallel-thread-execution/index.html#data-movement-and-conversion-instructions-shfl-sync

@netlify
Copy link

netlify bot commented Apr 7, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 3aebc18
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/624e92eafac72e0008c85ed6
😎 Deploy Preview https://deploy-preview-4734--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@qiao-bo qiao-bo changed the title [SIMT] [cuda] Use correct source lane offset for warp intrinsics [SIMT] [cuda] Use correct source lane offset for warp intrinsics Apr 7, 2022
Copy link
Member

@YuCrazing YuCrazing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@qiao-bo qiao-bo merged commit 8d0f395 into taichi-dev:master Apr 8, 2022
@qiao-bo qiao-bo deleted the bug branch April 8, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants