[build] [refactor] Move metal source files to target locations #5208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview canceled.
|
Co-authored-by: yekuang <k-ye@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #4832
One of the series of steps to split source files from backends, this PR addresses Metal:
taichi/runtime/metalfor targetmetal_runtime.taichi/runtime/program_impls/metalfor targetmetal_program_impl.taichi/backends/metal(Device API files) belongs to the targetmetal_rhi.The dependency relation is:
metal_rhi <- metal_runtime <- metal_program_impl <- core
In addition, this PR also breaks the usage of global file glob in Cmake core target (all sources were built under this target):
taichi/cmake/TaichiCore.cmake
Lines 94 to 96 in 71b8acc
This allows us to be explicit on which files are needed by which target.