Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Throw exceptions when ndrange gets non-integral arguments #5245

Merged
merged 4 commits into from
Jun 24, 2022
Merged

[bug] Throw exceptions when ndrange gets non-integral arguments #5245

merged 4 commits into from
Jun 24, 2022

Conversation

AD1024
Copy link
Contributor

@AD1024 AD1024 commented Jun 23, 2022

Related issue = #4478

@netlify
Copy link

netlify bot commented Jun 23, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 9f3e7d3
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62b4f2d15304d80008134dd2
😎 Deploy Preview https://deploy-preview-5245--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2022

CLA assistant check
All committers have signed the CLA.

@AD1024 AD1024 changed the title [fixes] Throw exceptions when ndrange gets non-integral arguments [bug] Throw exceptions when ndrange gets non-integral arguments Jun 23, 2022
Copy link
Contributor

@jim19930609 jim19930609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AD1024 AD1024 merged commit 1295fb6 into taichi-dev:master Jun 24, 2022
feisuzhu added a commit to feisuzhu/taichi that referenced this pull request Jul 4, 2022
feisuzhu added a commit that referenced this pull request Jul 5, 2022
* [bug] Accept numpy integers in ndrange (#5245)

* add static ndrange test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants