[llvm] Avoid creating new LLVM contexts when updating struct module #5397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
/rebase |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
taichi-gardener
force-pushed
the
cast_type
branch
from
05d48e5
to
256ba9b
Compare
jim19930609
reviewed
Jul 13, 2022
jim19930609
reviewed
Jul 13, 2022
jim19930609
reviewed
Jul 13, 2022
jim19930609
approved these changes
Jul 13, 2022
ailzhang
reviewed
Jul 13, 2022
| } | ||
| if (required->isPointerTy()) { | ||
| required = required->getPointerElementType(); | ||
| provided = provided->getPointerElementType(); |
There was a problem hiding this comment.
nit: is it cleaner to just return is_same_type(required->getPointerElementType(), provided->getPointerElementType()) here?
There was a problem hiding this comment.
Yeah... I'll send another pr to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #5252
Types in modules imported from file/other contexts may be renamed to "original_type.xxx" when the type is imported multiple times. So, we need to insert a pointer cast when the parameter type of a function is renamed.