Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[error] Throw proper error message when an Ndarray is passed in via ti.template #5457

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

ailzhang
Copy link
Contributor

@ailzhang ailzhang commented Jul 19, 2022

ti.types.ndarray itself is a template type so let's throw a better error
message when users misuse it.

fixes #5452

…i.template

ti.types.ndarray itself is a template type so let's throw a better error
message when users misuse it.
@netlify
Copy link

netlify bot commented Jul 19, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 8a1b59b
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62d64bbdf6319700080d260d
😎 Deploy Preview https://deploy-preview-5457--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@Morcki Morcki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Seems friendly to taichi-newer!

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strongoier strongoier merged commit 233123d into taichi-dev:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Got __getitem__ error when passing ndarray as template.
3 participants