Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lang] Improve error message for ggui on opengl backend #5509

Merged
merged 14 commits into from
Jul 26, 2022
Merged

[Lang] Improve error message for ggui on opengl backend #5509

merged 14 commits into from
Jul 26, 2022

Conversation

neozhaoliang
Copy link
Contributor

Related issue = #5462

@netlify
Copy link

netlify bot commented Jul 25, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 4195af1
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62de9ebee598bd0009cd2267
😎 Deploy Preview https://deploy-preview-5509--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@taichi-gardener taichi-gardener added this to In progress in Lang Features & Python Jul 25, 2022
ailzhang
ailzhang suggested changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't the best place to put this adhoc check, would you mind taking a look at check_ggui_availability and see if you can do anything over there?

@neozhaoliang
Copy link
Contributor Author

Thanks for the suggestion, the check is moved to check_ggui_availability.

ailzhang
ailzhang reviewed Jul 25, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm I'd prefer to have _ti_core.GGUI_AVAILABLE == false in this case... so I feel like it's better to do this check in C++?

@neozhaoliang
Copy link
Contributor Author

neozhaoliang commented Jul 25, 2022 •
edited
Loading

I agree. Setting GGUI_AVAILABLE in c++ is better since it's referenced elsewhere in python part.
I have moved the check to c++, but I'm not sure if it's in the right place?

ailzhang
ailzhang reviewed Jul 25, 2022
View reviewed changes
python/taichi/ui/utils.py Outdated Show resolved Hide resolved
ailzhang
ailzhang approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang ailzhang merged commit fdb7589 into taichi-dev:master Jul 26, 2022
Lang Features & Python automation moved this from In progress to Done Jul 26, 2022
@neozhaoliang neozhaoliang deleted the fix-ggui-opengl branch July 26, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang ailzhang approved these changes

@AmesingFlank AmesingFlank Awaiting requested review from AmesingFlank

Assignees
No one assigned
Labels
None yet
Projects
Lang Features & Python
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@neozhaoliang @ailzhang