-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gui] Add wareframe mode for mesh & mesh_instance, add slider_int for Window.GUI. #5576
Conversation
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
…ying ground-truth images
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Had a small suggestion w.r.t using enums instead of raw ints
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Dunfan Lu <ldfrank533@outlook.com>
Co-authored-by: YuZhang <YuCrazing@users.noreply.github.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a lot better! I had a few more nits inline and then this PR is good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, i still suggest you only to differentiate filled and wireframe draws, it would be a simple boolean instead of all the struggles with DisplayMode
. I cannot come up with a case that you wanna debug meshes without the connectivity information between vertices and you still don't think scene.particles
is a first choice. the structure of input field or ndarray ought to be the same either way.
I agree with that, I will pass a bool value to enable users to decide to show WareFrame mode or not to. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Note:
New features:
Fill Mode
(fill faces),Line Mode
(Wareframe),Point Mode
(rendering as points).slider_int
inwindow.GUI
, which supports slide int type value from minimum to maximum.instance_count
to control the count of mesh instances.Usage: