[build] [refactor] Decouple GUI source files from taichi_core target #5676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview canceled.
|
jim19930609
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #4832
taichi_uiandtaichi_ui_vulkantargetstaichi/guifiles intotaichi/uifield_infosource files totaichi_coreto break circular dependency betweentaichi_coreandtaichi_ui.At the moment we only decouple source files for ease of AOT testing. The compilation dependency remain unchanged, namely the CPU GUI files (now under
taichi/ui/gui) is always compiled and linked, while the GPU GGUI files (undertaichi/uiexceptgui) are guarded byTI_WITH_GGUI. Later we can also separate the compilation of GUI files.