Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] Reorder sparse matrix before solving #6886

Merged
merged 7 commits into from Dec 20, 2022

Conversation

FantasyVR
Copy link
Collaborator

Issue: #2906

Brief Summary

When solving a sparse linear system without reordering the system matrix, analyze_pattern and factorize would consume a lot of GPU memory. For example, the res in the stable fluid example can not be larger than 500. After reordering the sparse system matrix, we can set res=512 now.

@netlify
Copy link

netlify bot commented Dec 13, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit bfd7251
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63a11a7365332c00082e1b80
😎 Deploy Preview https://deploy-preview-6886--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@taichi-gardener taichi-gardener added this to In progress in Lang Features & Python Dec 13, 2022
taichi/program/sparse_solver.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@Hanke98 Hanke98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me ! Thanks!
PS: Sorry for the delayed response! I am busy working on my paper recently.

@FantasyVR
Copy link
Collaborator Author

The changes look good to me ! Thanks! PS: Sorry for the delayed response! I am busy working on my paper recently.

hhha, Never mind. If you don't have time, you can just ignore the review request.

@FantasyVR FantasyVR merged commit e9e8edd into taichi-dev:master Dec 20, 2022
Lang Features & Python automation moved this from In progress to Done Dec 20, 2022
@FantasyVR FantasyVR deleted the reorder branch December 22, 2022 04:03
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Issue: taichi-dev#2906 

### Brief Summary
When solving a sparse linear system without reordering the system
matrix, `analyze_pattern` and `factorize` would consume a lot of GPU
memory. For example, the `res` in the `stable fluid` example can not be
larger than 500. After reordering the sparse system matrix, we can set
`res=512` now.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants