Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] Fix scalarization for PrintStmt #6945

Merged
merged 5 commits into from Dec 23, 2022

Conversation

jim19930609
Copy link
Contributor

Issue: #6927

Brief Summary

@netlify
Copy link

netlify bot commented Dec 21, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 5ba7239
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63a4f56d8750ca0009bbd339
😎 Deploy Preview https://deploy-preview-6945--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@taichi-gardener taichi-gardener added this to In progress in Lang Features & Python Dec 21, 2022
@neozhaoliang
Copy link
Contributor

neozhaoliang commented Dec 22, 2022

There is a redundant , before each ]?

import taichi as ti

ti.init()

@ti.kernel
def test():
    v = ti.Matrix([[1., 2.], [3., 4.]])
    print(v)

test()

The output:

[[1.000000, 2.000000, ], [3.000000, 4.000000, ], ]

jim19930609 and others added 2 commits December 22, 2022 18:08
Co-authored-by: Zhao Liang <mathzhaoliang@gmail.com>
taichi/transforms/scalarize.cpp Outdated Show resolved Hide resolved
taichi/transforms/scalarize.cpp Outdated Show resolved Hide resolved
taichi/transforms/scalarize.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@neozhaoliang neozhaoliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jim19930609 jim19930609 merged commit bbe38aa into taichi-dev:master Dec 23, 2022
Lang Features & Python automation moved this from In progress to Done Dec 23, 2022
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Issue: taichi-dev#6927

### Brief Summary

Co-authored-by: Zhao Liang <mathzhaoliang@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants