Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Fix "const CompileConfig *" to "const CompileConfig &" #7243

Merged

Conversation

PGZXB
Copy link
Contributor

@PGZXB PGZXB commented Jan 28, 2023

@netlify
Copy link

netlify bot commented Jan 28, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 10e468a
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63d4ea97ab5f5c0009887b69
😎 Deploy Preview https://deploy-preview-7243--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PGZXB PGZXB changed the title Fix const CompileConfig * to const CompileConfig & [refactor] Fix const CompileConfig * to const CompileConfig & Jan 28, 2023
@PGZXB PGZXB changed the title [refactor] Fix const CompileConfig * to const CompileConfig & [refactor] Fix "const CompileConfig *" to "const CompileConfig &" Jan 28, 2023
Copy link
Contributor

@lin-hitonami lin-hitonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PGZXB PGZXB merged commit bea3127 into taichi-dev:master Jan 29, 2023
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
…ichi-dev#7243)

Issue: taichi-dev#7002,
taichi-dev#7159 (comment)

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants