Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Fix "const CompileConfig *" to "const CompileConfig &" (Part2) #7253

Conversation

PGZXB
Copy link
Contributor

@PGZXB PGZXB commented Jan 29, 2023

Issue: #7002

@netlify
Copy link

netlify bot commented Jan 29, 2023

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 158f911
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63d6612438facd0008d9ca01

@PGZXB PGZXB changed the title Fix "const CompileConfig *" to "const CompileConfig &" (Part2) [refactor] Fix "const CompileConfig *" to "const CompileConfig &" (Part2) Jan 29, 2023
Copy link
Collaborator

@bobcao3 bobcao3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

@ailzhang ailzhang merged commit 593caba into taichi-dev:master Jan 30, 2023
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
…rt2) (taichi-dev#7253)

Issue: taichi-dev#7002

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants