[Lang] Replace internal representation of Python-scope ti.Matrix with numpy arrays #7559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
ailzhang
approved these changes
Mar 17, 2023
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
… numpy arrays (taichi-dev#7559) Issue: taichi-dev#7447 ### Brief Summary This PR corresponds to step 3 of taichi-dev#7447. The code paths in `matrix.py` and `ops.py` have been significantly simplified: - The `Matrix` class, which is for Python scope, now only contains two cases, numpy arrays for values and nested lists for host access of `SNode`/`Ndarray`. Redundant internal functions have been removed. `dt` now has effects because numpy arrays have types. - No more `element_wise_xxx`, `uniform_matrix_inputs` and `@unary, @binary` decorators. The full dispatching logic for ops is in unique entrances `_unary_operation/_binary_operation`. Note that Python-scope matrix slicing is temporarily disabled in this PR because the feature itself is incomplete - only read is supported. It can be re-supported in a better way in the future. Taichi-scope matrix slicing still works properly. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7447
Brief Summary
This PR corresponds to step 3 of #7447. The code paths in
matrix.pyandops.pyhave been significantly simplified:Matrixclass, which is for Python scope, now only contains two cases, numpy arrays for values and nested lists for host access ofSNode/Ndarray. Redundant internal functions have been removed.dtnow has effects because numpy arrays have types.element_wise_xxx,uniform_matrix_inputsand@unary, @binarydecorators. The full dispatching logic for ops is in unique entrances_unary_operation/_binary_operation.Note that Python-scope matrix slicing is temporarily disabled in this PR because the feature itself is incomplete - only read is supported. It can be re-supported in a better way in the future. Taichi-scope matrix slicing still works properly.