Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Insert gc task only for pointer and dynamic SNode #781

Merged
merged 3 commits into from Apr 14, 2020
Merged

[Bug] Insert gc task only for pointer and dynamic SNode #781

merged 3 commits into from Apr 14, 2020

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Apr 14, 2020 •
edited

@k-ye k-ye requested a review from yuanming-hu April 14, 2020 12:20
@k-ye k-ye changed the title [Bug] Fix crash when calling deactivate() on bitmasked [Bug] Insert gc task only for pointer and dynamic SNode Apr 14, 2020
yuanming-hu
yuanming-hu approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. I'll implement zero-filling for bitmasked nodes based on this.

@yuanming-hu yuanming-hu merged commit d2d9d64 into taichi-dev:master Apr 14, 2020
@k-ye k-ye deleted the fix branch April 23, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanming-hu yuanming-hu yuanming-hu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@k-ye @yuanming-hu @taichi-gardener