Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Improve type checking error messages #797

Merged
merged 2 commits into from Apr 16, 2020

Conversation

yuanming-hu
Copy link
Member

No rush on reviewing this - just some random modifications while trying to fix #793

[Click here for the format server]

Copy link
Collaborator

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks like my assertion messages in verify.cpp can also be simplified.

taichi/common/interface.h Outdated Show resolved Hide resolved
taichi/transforms/type_check.cpp Show resolved Hide resolved
@yuanming-hu yuanming-hu merged commit 588e504 into taichi-dev:master Apr 16, 2020
@xumingkuan
Copy link
Collaborator

xumingkuan commented Apr 16, 2020

TI_ASSERT(x) with x containing {} fails now...

(I triggered this by writing a lambda expression in TI_ASSERT.)

@yuanming-hu
Copy link
Member Author

Is there an easy way to fix this? If no then I would say it will be easier if we do not use lamdas in TI_ASSERT...

@xumingkuan
Copy link
Collaborator

No, I think, as long as we're using SPD_AUGMENTED_LOG. It makes sense to me to not use lambdas in TI_ASSERT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange x86 codegen exception
3 participants