Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[async] Add parallel task executor #805

Merged
merged 3 commits into from Apr 17, 2020
Merged

[async] Add parallel task executor #805

merged 3 commits into from Apr 17, 2020

Conversation

yuanming-hu
Copy link
Member

xumingkuan
xumingkuan reviewed Apr 17, 2020
View reviewed changes
Copy link
Collaborator

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a few nits...

taichi/program/async_engine.h Outdated Show resolved Hide resolved
tests/cpp/test_parallel_executor.cpp Show resolved Hide resolved
tests/cpp/test_parallel_executor.cpp Outdated Show resolved Hide resolved
xumingkuan
xumingkuan approved these changes Apr 17, 2020
View reviewed changes
Copy link
Collaborator

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM now. Thanks!

@yuanming-hu yuanming-hu merged commit 74d8267 into taichi-dev:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xumingkuan xumingkuan xumingkuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yuanming-hu @xumingkuan