[IR] Fix illegal intermediate IRs #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xumingkuan
commented
Apr 17, 2020
Comment on lines
-492
to
+493
| b->statements.insert( | ||
| b->statements.begin() + i + 1, | ||
| Stmt::make<OffloadedStmt>(OffloadedStmt::TaskType::gc, snode)); | ||
| b->insert(Stmt::make<OffloadedStmt>(OffloadedStmt::TaskType::gc, snode), | ||
| i + 1); |
There was a problem hiding this comment.
Modifying Block::statements directly without setting parent was really bad...
If we set Block::statements to be private to prevent code fragments like this, we may need some functions like Block::get_statements() to keep code fragments like for (auto &stmt : b->statements) neat?
There was a problem hiding this comment.
Right, probably something like Block::get_statements() const.
yuanming-hu
approved these changes
Apr 17, 2020
Comment on lines
-492
to
+493
| b->statements.insert( | ||
| b->statements.begin() + i + 1, | ||
| Stmt::make<OffloadedStmt>(OffloadedStmt::TaskType::gc, snode)); | ||
| b->insert(Stmt::make<OffloadedStmt>(OffloadedStmt::TaskType::gc, snode), | ||
| i + 1); |
There was a problem hiding this comment.
Right, probably something like Block::get_statements() const.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #739.
All hotfixes are removed.
[Click here for the format server]