Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): correct resolve date range in mobile calendar #5974

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

Copy link

lumberjack-bot bot commented Nov 15, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Nov 15, 2023

Visit the preview URL for this PR (updated for commit a0b4e15):

https://taiga-ui--pr5974-splincode-fix-mobile-tvwq7t9a.web.app

(expires Thu, 30 Nov 2023 09:02:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Nov 15, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
374.78KB (+185B +0.05%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
198.18KB +10%
demo/browser/runtime.(hash).js
41.11KB +10%
demo/browser/polyfills.(hash).js
11.22KB +10%
demo/browser/styles.(hash).css
1.22KB +10%

Total files change +195B +0.03%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.28MB (+364B +0.02%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (ed02bda) 71.95% compared to head (a0b4e15) 71.93%.

Files Patch % Lines
...nents/mobile-calendar/mobile-calendar.component.ts 18.18% 8 Missing and 1 partial ⚠️
projects/kit/utils/date/update.ts 0.00% 3 Missing ⚠️
...alendar-dialog/mobile-calendar-dialog.component.ts 0.00% 2 Missing ⚠️
...nts/input-date-multi/input-date-multi.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5974      +/-   ##
==========================================
- Coverage   71.95%   71.93%   -0.02%     
==========================================
  Files        1462     1462              
  Lines       15982    15987       +5     
  Branches     2268     2273       +5     
==========================================
+ Hits        11500    11501       +1     
- Misses       4111     4115       +4     
  Partials      371      371              
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 59.43% <ø> (ø)
addon-mobile 60.49% <15.38%> (-0.13%) ⬇️
addon-table 60.75% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.65% <ø> (ø)
core 78.00% <ø> (ø)
kit 70.19% <33.33%> (-0.02%) ⬇️
summary 71.93% <21.05%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode force-pushed the splincode/fix/mobile branch 6 times, most recently from 0e583d5 to 6717c73 Compare November 20, 2023 08:12
projects/kit/utils/date/asserts.ts Outdated Show resolved Hide resolved
projects/kit/utils/date/update.ts Outdated Show resolved Hide resolved
projects/cdk/utils/miscellaneous/is-present.ts Outdated Show resolved Hide resolved
@splincode splincode force-pushed the splincode/fix/mobile branch 3 times, most recently from c274291 to f3d1721 Compare November 20, 2023 12:39
projects/core/components/dialog/dialog.service.ts Outdated Show resolved Hide resolved
projects/kit/utils/date/asserts.ts Outdated Show resolved Hide resolved
projects/kit/utils/date/update.ts Outdated Show resolved Hide resolved
@splincode splincode merged commit 016242e into main Nov 29, 2023
34 checks passed
@splincode splincode deleted the splincode/fix/mobile branch November 29, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants