Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experimental): Sensitive fix svg interruption in safari #6118

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

vladimirpotekhin
Copy link
Member

@vladimirpotekhin vladimirpotekhin commented Nov 28, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Closes #

What is the new behaviour?

viewBox removed from svg and preserveAspectRatio="none" added to fix aspect ratio issue in safari

Copy link

lumberjack-bot bot commented Nov 28, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Nov 28, 2023

Visit the preview URL for this PR (updated for commit 7b32129):

https://taiga-ui--pr6118-safari-sensitive-0i42rmbw.web.app

(expires Wed, 29 Nov 2023 13:44:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (572086f) 71.95% compared to head (7b32129) 71.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6118   +/-   ##
=======================================
  Coverage   71.95%   71.95%           
=======================================
  Files        1461     1461           
  Lines       15971    15971           
  Branches     2268     2268           
=======================================
  Hits        11492    11492           
  Misses       4108     4108           
  Partials      371      371           
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 59.43% <ø> (ø)
addon-mobile 60.61% <ø> (ø)
addon-table 60.75% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.65% <ø> (ø)
core 78.02% <ø> (ø)
kit 70.20% <ø> (ø)
summary 71.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Nov 28, 2023

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
374.29KB +10%
demo/browser/vendor.(hash).js
198.18KB +10%
demo/browser/runtime.(hash).js
41.11KB +10%
demo/browser/polyfills.(hash).js
11.22KB +10%
demo/browser/styles.(hash).css
1.22KB +10%

Total files change +6B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.28MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@waterplea waterplea merged commit ed02bda into main Nov 29, 2023
35 checks passed
@waterplea waterplea deleted the safari-sensitive branch November 29, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants