-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): *tuiHint
add new directive for customizing hint bubble
#6119
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Visit the preview URL for this PR (updated for commit d7a7809): https://taiga-ui--pr6119-hint-elhsfhe5.web.app (expires Wed, 29 Nov 2023 14:43:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
BundleMonFiles updated (2)
Unchanged files (3)
Total files change +304B +0.05% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6119 +/- ##
=======================================
Coverage 71.95% 71.95%
=======================================
Files 1461 1462 +1
Lines 15971 15982 +11
Branches 2268 2268
=======================================
+ Hits 11492 11500 +8
- Misses 4108 4111 +3
Partials 371 371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@Inject(TemplateRef) templateRef: TemplateRef<C>, | ||
@Inject(TuiHintDirective) hint: TuiHintDirective<C>, | ||
) { | ||
hint.component = new PolymorpheusComponent(TuiHintUnstyledComponent); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also pass INJECTOR
as the second argument ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it but it doesn't make any difference because it would only affect the unstyled component — the rest is a template using injector of declaration anyway.
PR Type
What kind of change does this PR introduce?
What is the current behaviour?
Closes #
What is the new behaviour?