Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): *tuiHint add new directive for customizing hint bubble #6119

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Closes #

What is the new behaviour?

Copy link

lumberjack-bot bot commented Nov 28, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

Visit the preview URL for this PR (updated for commit d7a7809):

https://taiga-ui--pr6119-hint-elhsfhe5.web.app

(expires Wed, 29 Nov 2023 14:43:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Nov 28, 2023

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
374.59KB (+318B +0.08%) +10%
demo/browser/runtime.(hash).js
41.1KB (-14B -0.03%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
198.18KB +10%
demo/browser/polyfills.(hash).js
11.22KB +10%
demo/browser/styles.(hash).css
1.22KB +10%

Total files change +304B +0.05%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.28MB (+959B +0.04%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0429be4) 71.95% compared to head (d7a7809) 71.95%.
Report is 1 commits behind head on main.

Files Patch % Lines
...ts/core/directives/hint/hint-unstyled.component.ts 66.66% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6119   +/-   ##
=======================================
  Coverage   71.95%   71.95%           
=======================================
  Files        1461     1462    +1     
  Lines       15971    15982   +11     
  Branches     2268     2268           
=======================================
+ Hits        11492    11500    +8     
- Misses       4108     4111    +3     
  Partials      371      371           
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 59.43% <ø> (ø)
addon-mobile 60.61% <ø> (ø)
addon-table 60.75% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.65% <ø> (ø)
core 78.00% <75.00%> (-0.02%) ⬇️
kit 70.20% <ø> (ø)
summary 71.95% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Inject(TemplateRef) templateRef: TemplateRef<C>,
@Inject(TuiHintDirective) hint: TuiHintDirective<C>,
) {
hint.component = new PolymorpheusComponent(TuiHintUnstyledComponent);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also pass INJECTOR as the second argument ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it but it doesn't make any difference because it would only affect the unstyled component — the rest is a template using injector of declaration anyway.

@splincode splincode merged commit c343d3e into main Nov 29, 2023
40 checks passed
@splincode splincode deleted the hint branch November 29, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants