Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layout): add tuiSlot action to be able to template any element into the action container of BlockStatus #6191

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

Nols1000
Copy link
Contributor

@Nols1000 Nols1000 commented Dec 7, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Only a and button elements are currently templated into the action container.

What is the new behavior?

Elements with the directive tuiSlot='action' are also templated into the action container.

Copy link

lumberjack-bot bot commented Dec 7, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

bundlemon bot commented Dec 7, 2023

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
379.18KB +10%
demo/browser/vendor.(hash).js
198.89KB +10%
demo/browser/runtime.(hash).js
39.55KB +10%
demo/browser/polyfills.(hash).js
11.25KB +10%
demo/browser/styles.(hash).css
1.22KB +10%

No change in files bundle size

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.3MB (+14B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ae1b05) 74.50% compared to head (7e99f20) 72.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6191      +/-   ##
==========================================
- Coverage   74.50%   72.03%   -2.47%     
==========================================
  Files        1120     1457     +337     
  Lines       12244    16010    +3766     
  Branches     1866     2284     +418     
==========================================
+ Hits         9122    11533    +2411     
- Misses       2814     4104    +1290     
- Partials      308      373      +65     
Flag Coverage Δ
addon-charts 71.46% <ø> (?)
addon-doc 60.28% <ø> (?)
addon-mobile 60.65% <ø> (?)
addon-table 60.75% <ø> (?)
addon-tablebars 96.15% <ø> (ø)
cdk 78.73% <ø> (ø)
core 77.96% <ø> (ø)
kit 70.23% <ø> (ø)
summary 72.03% <ø> (-2.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nols1000 Nols1000 changed the title Add tuiSlot 'action' to be able to template any element into the action container of BlockStatus feat(layout): add tuiSlot 'action' to be able to template any element into the action container of BlockStatus Dec 7, 2023
@waterplea
Copy link
Collaborator

Hi @Nols1000, thank you for this PR! If you have time, would you mind taking a look a this issue while you're in this component?
#6139
At a glance, it seems like there's just some :empty + display: none missing.

@splincode splincode changed the title feat(layout): add tuiSlot 'action' to be able to template any element into the action container of BlockStatus feat(layout): add tuiSlot action to be able to template any element into the action container of BlockStatus Dec 12, 2023
@splincode splincode merged commit a9a5cc8 into taiga-family:main Dec 12, 2023
37 checks passed
@Nols1000
Copy link
Contributor Author

Hi @waterplea, thanks for bringing this to my attention. I'll take a look later.

@Nols1000 Nols1000 deleted the patch-1 branch December 12, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants