Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): Push allow string in timestamp for custom formatting #6209

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Closes #

What is the new behaviour?

Copy link

lumberjack-bot bot commented Dec 11, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 8ccdc0e):

https://taiga-ui--pr6209-push-uju8wscz.web.app

(expires Tue, 12 Dec 2023 08:13:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Dec 11, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
379.19KB (+23B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
214.33KB +10%
demo/browser/runtime.(hash).js
39.54KB +10%
demo/browser/polyfills.(hash).js
11.25KB +10%
demo/browser/styles.(hash).css
1.22KB +10%

Total files change +20B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.31MB (+34B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a69fc25) 72.02% compared to head (8ccdc0e) 68.58%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6209      +/-   ##
==========================================
- Coverage   72.02%   68.58%   -3.44%     
==========================================
  Files        1457      731     -726     
  Lines       16010     9110    -6900     
  Branches     2284     1272    -1012     
==========================================
- Hits        11531     6248    -5283     
+ Misses       4106     2648    -1458     
+ Partials      373      214     -159     
Flag Coverage Δ
addon-charts 85.44% <ø> (+13.98%) ⬆️
addon-doc 60.28% <ø> (ø)
addon-mobile 60.65% <ø> (ø)
addon-table 60.75% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk ∅ <ø> (∅)
core ∅ <ø> (∅)
kit 70.23% <100.00%> (+<0.01%) ⬆️
summary 68.58% <100.00%> (-3.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waterplea waterplea merged commit 33525f6 into main Dec 11, 2023
38 checks passed
@waterplea waterplea deleted the push branch December 11, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants