Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schematics): add manual migration #7458

Merged
merged 1 commit into from
May 16, 2024
Merged

feat(schematics): add manual migration #7458

merged 1 commit into from
May 16, 2024

Conversation

splincode
Copy link
Member

@splincode splincode commented May 16, 2024

npx schematics @taiga-ui/cdk:updateToV3_78 --allow-private --skip-deep-imports --dry-run false --experimental

Copy link
Contributor

sweep-ai bot commented May 16, 2024

Sweep: PR Review

Sweep has finished reviewing your pull request.

projects/cdk/schematics/collection.json

A new private schematic "updateToV3_78" has been added to the configuration file to handle the migration of proprietary icons.

Potential Issues

  • The new schematic "updateToV3_78" uses the same schema file as "updateToV3", which may not be appropriate if the migration requirements differ.
  • "updateToV3_78": {
    "private": true,
    "description": "Manually run migration to update proprietary icons",
    "factory": "./ng-update/v3-78/index#updateToV3_78",
    "schema": "./ng-update/v3-78/schema.json"


Copy link

lumberjack-bot bot commented May 16, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented May 16, 2024

Visit the preview URL for this PR (updated for commit 97cdecc):

https://taiga-ui--pr7458-splincode-manual-f2qr1nmf.web.app

(expires Fri, 17 May 2024 14:13:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented May 16, 2024

BundleMon

Files added (5)
Status Path Size Limits
demo/browser/main.(hash).js
+391.47KB +10%
demo/browser/vendor.(hash).js
+214.57KB +10%
demo/browser/runtime.(hash).js
+41.29KB +10%
demo/browser/polyfills.(hash).js
+11.25KB +10%
demo/browser/styles.(hash).css
+1.39KB +10%

Total files change +659.98KB

Groups added (1)
Status Path Size Limits
demo/browser/*..js
+2.4MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

"private": true,
"description": "Manually run migration to update proprietary icons",
"factory": "./ng-update/v3-78/index#updateToV3_78",
"schema": "./ng-update/v3/schema.json"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3 schema.json does not contains experimental property

"properties": {
"skip-deep-imports": {
"description": "Ignore deep imports replacements",
"type": "boolean",
"default": false
}
}

Should we create the separate ./ng-update/v3-78/schema.json and use it here ?

@splincode splincode merged commit f96c494 into v3.x May 16, 2024
32 checks passed
@splincode splincode deleted the splincode/manual branch May 16, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants