Fixing empty body bug in github webhooks

taigaio · Mar 18, 2015 · 3877411 · 3877411
1 parent a1e2a94
commit 3877411
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/taiga/hooks/github/event_hooks.py b/taiga/hooks/github/event_hooks.py
@@ -91,6 +91,9 @@ def _change_status(self, ref, status_slug, github_user):
 
 
 def replace_github_references(project_url, wiki_text):
+    if wiki_text == None:
+        wiki_text = ""
+
     template = "\g<1>[GitHub#\g<2>]({}/issues/\g<2>)\g<3>".format(project_url)
     return re.sub(r"(\s|^)#(\d+)(\s|$)", template, wiki_text, 0, re.M)
 

diff --git a/tests/integration/test_hooks_github.py b/tests/integration/test_hooks_github.py
@@ -455,3 +455,4 @@ def test_replace_github_references():
     assert event_hooks.replace_github_references("project-url", " #2 ") == " [GitHub#2](project-url/issues/2) "
     assert event_hooks.replace_github_references("project-url", " #2") == " [GitHub#2](project-url/issues/2)"
     assert event_hooks.replace_github_references("project-url", "#test") == "#test"
+    assert event_hooks.replace_github_references("project-url", None) == ""