Not existing neighbor return None, not empty dict

taigaio · Jan 4, 2016 · ae65db6 · ae65db6
1 parent 8445510
commit ae65db6
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/taiga/projects/issues/serializers.py b/taiga/projects/issues/serializers.py
@@ -81,7 +81,9 @@ class Meta:
 
 class IssueNeighborsSerializer(NeighborsSerializerMixin, IssueSerializer):
     def serialize_neighbor(self, neighbor):
-        return NeighborIssueSerializer(neighbor).data
+        if neighbor:
+            return NeighborIssueSerializer(neighbor).data
+        return None
 
 
 class NeighborIssueSerializer(serializers.ModelSerializer):

diff --git a/taiga/projects/tasks/serializers.py b/taiga/projects/tasks/serializers.py
@@ -79,7 +79,9 @@ class Meta:
 
 class TaskNeighborsSerializer(NeighborsSerializerMixin, TaskSerializer):
     def serialize_neighbor(self, neighbor):
-        return NeighborTaskSerializer(neighbor).data
+        if neighbor:
+            return NeighborTaskSerializer(neighbor).data
+        return None
 
 
 class NeighborTaskSerializer(serializers.ModelSerializer):

diff --git a/taiga/projects/userstories/serializers.py b/taiga/projects/userstories/serializers.py
@@ -113,7 +113,9 @@ class Meta:
 
 class UserStoryNeighborsSerializer(NeighborsSerializerMixin, UserStorySerializer):
     def serialize_neighbor(self, neighbor):
-        return NeighborUserStorySerializer(neighbor).data
+        if neighbor:
+            return NeighborUserStorySerializer(neighbor).data
+        return None
 
 
 class NeighborUserStorySerializer(serializers.ModelSerializer):