Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Terraform 0.12 SDK #10

Merged
merged 3 commits into from
May 2, 2020
Merged

Upgrade to Terraform 0.12 SDK #10

merged 3 commits into from
May 2, 2020

Conversation

taiidani
Copy link
Owner

@taiidani taiidani commented May 2, 2020

Running the tf-migrate tool on the codebase and updating documentation. Look at how tiny the go.mod file became!

Fixes #6

Note that the acceptance test failures have been happening prior to this PR. This has been called out as a separate issue in #9.

@taiidani taiidani added this to the 0.4 milestone May 2, 2020
@taiidani
Copy link
Owner Author

taiidani commented May 2, 2020

@ttpp8794 would you like to test to confirm that this resolves your issue before it gets merged in?

@taiidani
Copy link
Owner Author

taiidani commented May 2, 2020

@ttpp8794 Fixing the acceptance tests involved bumping the upstream Jenkins library. I'm going to ask that you test that #11 PR instead and will merge this in now.

@taiidani taiidani merged commit d8f3117 into master May 2, 2020
@taiidani taiidani deleted the feature/Terraform012 branch May 2, 2020 17:35
@ttpp8794
Copy link

ttpp8794 commented May 4, 2020

@taiidani, thank you for quick fixing the issue. The provider issue looks get resolved. Can I use the latest changes in master branch now or should I wait until you fix the acceptance test issue?

@taiidani
Copy link
Owner Author

taiidani commented May 5, 2020

@ttpp8794 Thankfully fixing the acceptance test was as simple as upgrading the upstream library (#11), so it should be good to go in master now! I have also tagged 0.4.0 in case consumers prefer pinning to semver tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants