Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh Documentation #37

Merged
merged 4 commits into from
Mar 24, 2021
Merged

Refresh Documentation #37

merged 4 commits into from
Mar 24, 2021

Conversation

taiidani
Copy link
Owner

Dependencies

Holding on merge for the impending #36, which is adding new resource documentation.

What Is Changing

Updating documentation to conform to TF 0.14+'s more strict fmt rules, which automatically add quotes around resource types and names.

Fixing a typo where the examples use JENKINS_SERVER_URL as the env var rather than JENKINS_URL.

Fixes #34

Test Steps

make testacc

@taiidani taiidani added this to the 0.7 milestone Mar 21, 2021
@taiidani taiidani changed the title Feature/refresh docs Refresh Documentation Mar 21, 2021
@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #37 (de50a7e) into master (afcabfc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   80.81%   80.81%           
=======================================
  Files          15       15           
  Lines         886      886           
=======================================
  Hits          716      716           
  Misses        132      132           
  Partials       38       38           
Flag Coverage Δ
acceptance 80.81% <ø> (ø)
unit 58.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afcabfc...de50a7e. Read the comment docs.

@taiidani taiidani merged commit 8af9c1c into master Mar 24, 2021
@taiidani taiidani deleted the feature/RefreshDocs branch March 24, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JENKINS_SERVER_URL env variable is not respected
1 participant