-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource: jenkins_credential_ssh #46
Conversation
Signed-off-by: Jacek Kikiewicz <public@kikiewicz.com>
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
========================================
Coverage 80.80% 80.81%
========================================
Files 16 17 +1
Lines 1016 1157 +141
========================================
+ Hits 821 935 +114
- Misses 152 173 +21
- Partials 43 49 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@taiidani any update here ? ;) |
@jaceq Sorry about this! New job means more distractions. I promise I'll review this weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High quality as usual @jaceq! I caught one thing around the privatekey paths, but otherwise LGTM
Thank you for making that correction (and sorry for missing this). |
What Is Changing
Added new resource: credential_ssh allowing to store SSH key in jenkins.
Test Steps
make test make testacc