Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource: jenkins_credential_ssh #46

Merged
merged 3 commits into from
May 23, 2021
Merged

Resource: jenkins_credential_ssh #46

merged 3 commits into from
May 23, 2021

Conversation

jaceq
Copy link
Contributor

@jaceq jaceq commented May 6, 2021

What Is Changing

Added new resource: credential_ssh allowing to store SSH key in jenkins.

Test Steps

make test
make testacc

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #46 (b6c4a87) into master (0cc32a9) will increase coverage by 0.00%.
The diff coverage is 80.85%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master      #46    +/-   ##
========================================
  Coverage   80.80%   80.81%            
========================================
  Files          16       17     +1     
  Lines        1016     1157   +141     
========================================
+ Hits          821      935   +114     
- Misses        152      173    +21     
- Partials       43       49     +6     
Flag Coverage Δ
acceptance 80.81% <80.85%> (+<0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jenkins/resource_jenkins_credential_ssh.go 80.71% <80.71%> (ø)
jenkins/provider.go 89.09% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cc32a9...b6c4a87. Read the comment docs.

@jaceq
Copy link
Contributor Author

jaceq commented May 17, 2021

@taiidani any update here ? ;)

@taiidani
Copy link
Owner

@jaceq Sorry about this! New job means more distractions. I promise I'll review this weekend.

@taiidani taiidani self-assigned this May 23, 2021
@taiidani taiidani added this to the 0.7 milestone May 23, 2021
Copy link
Owner

@taiidani taiidani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High quality as usual @jaceq! I caught one thing around the privatekey paths, but otherwise LGTM

example/credentials_ssh.tf Outdated Show resolved Hide resolved
docs/resources/credential_ssh.md Outdated Show resolved Hide resolved
@taiidani taiidani merged commit de9ffa2 into taiidani:master May 23, 2021
@jaceq
Copy link
Contributor Author

jaceq commented May 25, 2021

Thank you for making that correction (and sorry for missing this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants