Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Namespace attribute for credential_vault_approle #69

Merged
merged 7 commits into from
Dec 18, 2021

Conversation

JVanAartsen
Copy link
Contributor

@JVanAartsen JVanAartsen commented Nov 13, 2021

Dependencies

What Is Changing

Adding support for Namespace parameter to Jenkins Vault Approle Credential

Test Steps

  • Have you updated the docs/ folder to match your change?
  • Have you exercised your change using the examples/ docker compose setup?
make testacc

@taiidani taiidani self-assigned this Dec 18, 2021
@taiidani taiidani added this to the 0.10 milestone Dec 18, 2021
@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #69 (ff431c3) into main (aac2fe0) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   81.91%   82.10%   +0.18%     
==========================================
  Files          17       17              
  Lines        1261     1274      +13     
==========================================
+ Hits         1033     1046      +13     
  Misses        180      180              
  Partials       48       48              
Flag Coverage Δ
acceptance 82.10% <100.00%> (+0.18%) ⬆️
unit 54.31% <76.92%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ns/data_source_jenkins_credential_vault_approle.go 100.00% <100.00%> (ø)
...nkins/resource_jenkins_credential_vault_approle.go 82.55% <100.00%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac2fe0...ff431c3. Read the comment docs.

Copy link
Owner

@taiidani taiidani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comprehensive updates! Confirmed that the changes work via the example/ repo, and tests passing.

@taiidani taiidani merged commit 1639d0a into taiidani:main Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants