allow players at join spawns without a spawn point yet generated due exhaustions pregens #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exhaustion pregens * clarify the `spawn_anyhere`setting in readme and API definition, as pointed at taikedz-mt#15 (comment) * when players join and there's no spawns, used a last resource of gen around fixed point: if no pregen around newpos, used the already valid random_pos, that is still valid * this solves the bug that players cannot do anything at server join, cos pregens is exahusted * **NOTE** spawn point still are not set, but players can spawns until a valid one is set * removed `rspawn.kick_on_fail or attempts <= 0`, just leave `rspawn.kick_on_fail`: i noted never raised that condition.. i set the setting to true but never kicked the player i was in suspect that must be `rspawn.kick_on_fail and attempts <= 0` cos player will be kicked only when there's no more attempts * i set `fixedpos.y = water_level + rspawn.search_radius` as fackback bypass of a valid air node.. is a ugly hack, but take note that there's no more attempts here so we need to let player to just get in if no `rspawn.kick_on_fail` is desired.. the search radius is not a valid "altitude" but serves as falback if user do not defined a valid spawn point and the fixed one is still a solid node (not air)! This is a ugly hack of the explanation on taikedz-mt#15 (comment) if `spawn_anyhere` is on false, then using my code will spawn in 0,0,0 or fixed defined in minetest.conf, otherwise will spawn anywhere inside limits of rspawn max and min.. so admins must fine tuned that! * Fixed closes close taikedz-mt#14
mckaygerhard
commented
Nov 9, 2021
| * `rspawn.spawn_anywhere` - whether to spawn anywhere in the world at sea level | ||
| * default `true` | ||
| * if `false`, will randomize around the static spawn point | ||
| * `rspawn.spawn_anywhere` - whether to spawn anywhere in the world at sea level (limited by the bounds spawn limits, check below) |
There was a problem hiding this comment.
upss .. miscpelled here but ignore this. i'll fix later.. after you reviewed the hole pull merge request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, when pregens cannot gen new spawn points players at joining to the server cannot spawn (cos there's no spawn point yet for it) so canot have a valid vision of the server around.. so canot play, this able to join and play but still not have a valid spawn point.. so use a randomixed around the falback fixed.
spawn_anyheresetting in readme and API definition, as pointedat WIP: Fixed exhaustion bug bigservers #15 (comment)
if no pregen around newpos, used the already valid random_pos, that is still valid
rspawn.kick_on_fail or attempts <= 0, just leaverspawn.kick_on_fail:i noted never raised that condition.. i set the setting to true but never kicked the player
i was in suspect that must be
rspawn.kick_on_fail and attempts <= 0cos player will bekicked only when there's no more attempts
fixedpos.y = water_level + rspawn.search_radiusas fackback bypass of a valid air node..is a ugly hack, but take note that there's no more attempts here so we need to let player to just get in
if no
rspawn.kick_on_failis desired.. the search radius is not a valid "altitude" but servesas falback if user do not defined a valid spawn point and the fixed one is still a solid node (not air)!
This is a ugly hack of the explanation on WIP: Fixed exhaustion bug bigservers #15 (comment)
if
spawn_anyhereis on false, then using my code will spawn in 0,0,0 or fixed defined in minetest.conf,otherwise will spawn anywhere inside limits of rspawn max and min.. so admins must fine tuned that!