Skip to content

Commit

Permalink
Update actions/cache from 3 to 4
Browse files Browse the repository at this point in the history
  • Loading branch information
taiki-e committed Apr 26, 2024
1 parent c1c0be4 commit 0ba1a6b
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ jobs:
fail-fast: false
matrix:
container:
- ubuntu:18.04 # glibc 2.27
- ubuntu:20.04 # glibc 2.31
- ubuntu:22.04 # glibc 2.35
- ubuntu:24.04 # glibc 2.39
Expand All @@ -104,7 +103,6 @@ jobs:
- almalinux:8-minimal # glibc 2.28
- almalinux:9 # glibc 2.34
- almalinux:9-minimal # glibc 2.34
- centos:7 # glibc 2.17
- archlinux:latest # glibc 2.38 (as of 2024-04-18)
- alpine:latest # musl 1.2.4 (as of alpine 3.19)
runs-on: ubuntu-latest
Expand All @@ -120,7 +118,7 @@ jobs:
echo "$HOME/.cargo/bin" >>"${GITHUB_PATH}"
apt-get -qq -o Dpkg::Use-Pty=0 remove -y curl
if: startsWith(matrix.container, 'ubuntu') || startsWith(matrix.container, 'debian')
- name: Install requirements (fedora/almalinux/centos)
- name: Install requirements (fedora/almalinux)
run: |
set -eEuxo pipefail
if type -P dnf &>/dev/null; then
Expand All @@ -132,7 +130,7 @@ jobs:
fi
curl --proto '=https' --tlsv1.2 -fsSL --retry 10 https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain stable --no-modify-path
echo "$HOME/.cargo/bin" >>"${GITHUB_PATH}"
if: startsWith(matrix.container, 'fedora') || startsWith(matrix.container, 'almalinux') || startsWith(matrix.container, 'centos')
if: startsWith(matrix.container, 'fedora') || startsWith(matrix.container, 'almalinux')
- name: Install requirements (archlinux)
run: pacman -Sy --noconfirm rust
if: startsWith(matrix.container, 'archlinux')
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ Note: In this file, do not use the hard wrap in the middle of a sentence for com

## [Unreleased]

- Update `actions/cache` from 3 to 4.

This [breaks compatibility with CentOS 7 and Ubuntu 18.04](https://github.com/actions/runner/issues/2906) so it is treated as a breaking change.

## [1.4.0] - 2024-04-26

- Improve support for Arch based containers/self-hosted runners.
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ The interface of this action is a subset of the interface of [install-action], s

## Compatibility

This action has been tested for GitHub-hosted runners (Ubuntu, macOS, Windows) and containers (Ubuntu, Debian, Fedora, CentOS, Alma, Arch, Alpine).
This action has been tested for GitHub-hosted runners (Ubuntu, macOS, Windows) and containers (Ubuntu, Debian, Fedora, Alma, Arch, Alpine).
To use this action in self-hosted runners or in containers, at least the following tools are required:

- bash
Expand Down
3 changes: 1 addition & 2 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ runs:
INPUT_REV: ${{ inputs.rev }}
- name: Restore Cache
id: cache
# TODO: currently, we cannot update to v4 because node20 doesn't work on CentOS 7: https://github.com/actions/runner/issues/2906
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ${{ steps.pre.outputs.path }}
key: ${{ steps.pre.outputs.key }}
Expand Down

0 comments on commit 0ba1a6b

Please sign in to comment.