Improve error message when no rust-version field is specified #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
reviewed
Sep 11, 2023
src/rustup.rs
Outdated
| @@ -82,7 +82,7 @@ pub(crate) fn version_range( | |||
| }; | |||
| } | |||
| let Some(lowest_msrv) = lowest_msrv else { | |||
| bail!("no rust-version field in Cargo.toml is specified") | |||
| bail!("no rust-version field in any Cargo.toml is specified") | |||
There was a problem hiding this comment.
"selected Cargo.toml's" instead of "any Cargo.toml"
(part of my problem was I forgot --workspace)
taiki-e
force-pushed
the
rust-version
branch
from
0043fd7
to
e463ebf
Compare
epage
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make error messages easier to understand in cases like https://github.com/rust-lang/cargo/actions/runs/6147097200/job/16677799392?pr=12654.
FYI @epage