Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --feature-powerset subcommand #23

Merged
merged 2 commits into from
Dec 9, 2019

Conversation

kleimkuhler
Copy link
Contributor

Motivation

I have recently been using cargo-hack for the --each-feature subcommand.
It has been very helpful! However, I have been testing feature combinations
manually.

The crate I've been using this for supports any combination of features, so it
seemed like a --feature-powerset subcommand could be useful to contribute.

Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@taiki-e
Copy link
Owner

taiki-e commented Dec 9, 2019

bors r+

bors bot added a commit that referenced this pull request Dec 9, 2019
23: Add `--feature-powerset` subcommand r=taiki-e a=kleimkuhler

## Motivation

I have recently been using `cargo-hack` for the `--each-feature` subcommand.
It has been very helpful! However, I have been testing feature combinations
manually.

The crate I've been using this for supports any combination of features, so it
seemed like a `--feature-powerset` subcommand could be useful to contribute.


Co-authored-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
@bors
Copy link
Contributor

bors bot commented Dec 9, 2019

Build succeeded

  • style (clippy)
  • style (rustfmt)
  • test (macos-latest, 1.36.0)
  • test (macos-latest, nightly)
  • test (macos-latest, stable)
  • test (ubuntu-latest, 1.36.0)
  • test (ubuntu-latest, nightly)
  • test (ubuntu-latest, stable)
  • test (windows-latest, 1.36.0)
  • test (windows-latest, nightly)
  • test (windows-latest, stable)

@bors bors bot merged commit 26903ed into taiki-e:master Dec 9, 2019
@kleimkuhler kleimkuhler deleted the kleimkuhler/add-feature-powerset branch December 9, 2019 03:45
@taiki-e
Copy link
Owner

taiki-e commented Dec 9, 2019

Published in 0.3.2.

@kleimkuhler
Copy link
Contributor Author

Great thanks!

@taiki-e taiki-e added the A-features Area: features (--feature-powerset, --each-feature, etc.) label Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants