Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that cargo-hack is runnable on Cargo versions older than MSRV #71

Merged
merged 2 commits into from
Oct 18, 2020

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Oct 18, 2020

cargo-hack is usually runnable with Cargo versions older than the Rust version required for installation (e.g., cargo +1.31.0 hack check). To run the current cargo-hack requires Cargo 1.26 or later.

@taiki-e taiki-e force-pushed the run-msrv branch 5 times, most recently from f4b680c to 0723374 Compare October 18, 2020 20:39
cargo-hack is usually runnable with Cargo versions older than the Rust
version required for installation.
@taiki-e

This comment has been minimized.

bors bot added a commit that referenced this pull request Oct 18, 2020
71: Test that cargo-hack is runnable on Cargo versions older than MSRV r=taiki-e a=taiki-e

cargo-hack is runnable with Cargo versions older than the Rust version required for installation (e.g., `cargo +1.31.0 hack check`). To run the current cargo-hack requires Cargo 1.26 or later.


Co-authored-by: Taiki Endo <te316e89@gmail.com>
@taiki-e

This comment has been minimized.

@bors

This comment has been minimized.

@taiki-e
Copy link
Owner Author

taiki-e commented Oct 18, 2020

bors r-
bors r+

@bors
Copy link
Contributor

bors bot commented Oct 18, 2020

Canceled.

@bors
Copy link
Contributor

bors bot commented Oct 18, 2020

Build succeeded:

@bors bors bot merged commit 70fd874 into master Oct 18, 2020
@bors bors bot deleted the run-msrv branch October 18, 2020 20:54
bors bot added a commit that referenced this pull request Jan 19, 2021
109: Improve testing for old cargo/rustc r=taiki-e a=taiki-e

This allows us to run the full test suite on cargo/rustc that is older than the version required for the building cargo-hack from the source.

Related: #71

Co-authored-by: Taiki Endo <te316e89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant