Fix show-env subcommand bug #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
commented
Jan 6, 2022
Comment on lines
306
to
309
| ```sh | ||
| cargo llvm-cov clean --workspace # remove artifacts that may affect the coverage results | ||
| source <(cargo llvm-cov show-env --export-prefix) | ||
| cargo llvm-cov clean --workspace # remove artifacts that may affect the coverage results | ||
| cargo build # build rust binaries |
There was a problem hiding this comment.
The order is important because cargo llvm-cov clean --workspace needs to refer to the CARGO_LLVM_COV_TARGET_DIR set by show-env.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem that the readme example does not work.
This probably fixes the remaining problem reported in #115.
cc #93
cc @davidhewitt