fix: add --coverage-target-only, to use rustflags only for target
#167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! CI is not starting somehow, so I'll close and immediately reopen this PR to fix it. |
Use `CARGO_TARGET_{target}_RUSTFLAGS` rather than `RUSTFLAGS`,
if `--target <TRIPLE>` and `--coverage-target-only` is specified.
This is important, if the project uses multiple targets via the cargo
`bindeps` feature, and not all targets can use `instrument-coverage`,
e.g. a microkernel, or an embedded binary.
Signed-off-by: Harald Hoyer <harald@profian.com>
haraldh
force-pushed
the
coverage_target_only
branch
from
7ebd874
to
09a502a
Compare
|
1 workflow awaiting approval |
|
Build succeeded: |
bstrie
added a commit
to bstrie/enarx
that referenced
this pull request
May 23, 2022
This uses the new flag added in taiki-e/cargo-llvm-cov#167 Signed-off-by: bstrie <865233+bstrie@users.noreply.github.com>
enarxbot
pushed a commit
to enarx/enarx
that referenced
this pull request
May 23, 2022
This uses the new flag added in taiki-e/cargo-llvm-cov#167 Signed-off-by: bstrie <865233+bstrie@users.noreply.github.com>
|
Published in 0.4.1. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
CARGO_TARGET_{target}_RUSTFLAGSrather thanRUSTFLAGS,if
--target <TRIPLE>and--coverage-target-onlyis specified.This is important, if the project uses multiple targets via the cargo
bindepsfeature, and not all targets can useinstrument-coverage,e.g. a microkernel, or an embedded binary.
Signed-off-by: Harald Hoyer harald@profian.com