Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --fail-under-{functions,regions} options #323

Merged
merged 1 commit into from
Nov 17, 2023
Merged

add --fail-under-{functions,regions} options #323

merged 1 commit into from
Nov 17, 2023

Conversation

CobaltCause
Copy link
Contributor

No description provided.

@CobaltCause CobaltCause force-pushed the fail-under-more branch 2 times, most recently from 7110828 to 9a556cc Compare November 16, 2023 06:40
@CobaltCause
Copy link
Contributor Author

CobaltCause commented Nov 16, 2023 •
edited

CI appears to be failing because a dependency has added a build.rs in a minor release and cargo-llvm-cov has no lockfile...

taiki-e
taiki-e reviewed Nov 16, 2023
View reviewed changes
Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could you add a test like test_get_lines_percent?

As for CI failure, is has been fixed in the main branch.

@CobaltCause
Copy link
Contributor Author

Could you add a test like test_get_lines_percent?

Good call, that caught a typo in my impl AsRef<str> for CoverageKind.

@CobaltCause
add --fail-under-{functions,regions} options
541c4ab 
Not including one for branches since Rust itself doesn't support it.
@taiki-e taiki-e merged commit 548ab25 into taiki-e:main Nov 17, 2023
18 checks passed
@taiki-e
Copy link
Owner

taiki-e commented Nov 17, 2023

Published in v0.5.37.

@CobaltCause CobaltCause deleted the fail-under-more branch November 17, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CobaltCause @taiki-e