Support omitting patch/minor version in @version syntax

[Emilgardis]

Would like to be able to specify the minimal (and max) version for a tool to install.

Would enable the following

uses: taiki-e/install-action@v1
      with:
        tool: cargo-llvm-cov@~0.5

[Emilgardis]

Encountered in cross-rs/cross#1042 (comment)

[taiki-e]

Thanks for the suggestion. Omitting the patch/minor version is already supported in some packages, and what you actually need for your use case is not to support the (complex) semver requirement, but to support omitting the patch/minor version in other packages as well, right?

install-action/.github/workflows/ci.yml

Lines 32 to 33 in e85ee51

	# Nextest supports basic version ranges as well
	- nextest@0.9

[Emilgardis]

Yes! Nothing fancy needed

So this issue is not present on some of the packages, with some being those installed via binstall ?

[NobodyXu]

cargo-binstall already supports this, i.e. cargo binstall 'cargo-llvm-cov@~0.5' or cargo binstall --version '~0.5' cargo-llvm-cov.

[Emilgardis]

My comment was written in reverse, the issue is not present in those installed by cargo-bininstall I presume because of that

[NobodyXu]

My comment was written in reverse, the issue is not present in those installed by cargo-bininstall I presume because of that

Oh sorry :D

[taiki-e]

It is the unexpected behavior that ~ is accepted when binstall is used as a fallback. If that was the intended behavior, officially supporting a new package would always be a breaking change.

[NobodyXu]

officially supporting a new package would always be a breaking change

Sorry that I didn't quite understand this.
Why would supporting a new package be a breaking change?

[taiki-e]

officially supporting a new package would always be a breaking change

Sorry that I didn't quite understand this. Why would supporting a new package be a breaking change?

1. Users install crate X using install-action's binstall fallback with ~ requirement. (Assumption: install-action does not support crate X, but crate X support installation via binstall)
2. install-action now supports crate X. (No support for ~ requirements)
3. Workflow to install crate X using ~ requirement became broken because it ~ requirement is now not supported.

[NobodyXu]

Workflow to install crate X using ~ requirement became broken because it ~ requirement is now not supported.

Thanks for the explanation, I got it.
So I think the solution is to reject version that contains any operator and make sure it only contains digits and ., I can submit a PR for this fix.

[NobodyXu]

It is the unexpected behavior that ~ is accepted when binstall is used as a fallback. If that was the intended behavior, officially supporting a new package would always be a breaking change.

@taiki-e This is fixed in #26

[taiki-e]

This has been supported in 2.0.0 (taiki-e/install-action@v2).