Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cargo llvm-cov to use new report subcommand #1042

Merged
merged 1 commit into from
Oct 2, 2022

Conversation

Emilgardis
Copy link
Member

No description provided.

@Emilgardis Emilgardis requested a review from a team as a code owner October 2, 2022 16:05
@Emilgardis
Copy link
Member Author

bors try --none

bors bot added a commit that referenced this pull request Oct 2, 2022
@Alexhuszagh
Copy link
Contributor

This will always install the latest version of cargo-llvm-cov, correct?

@Emilgardis
Copy link
Member Author

This will always install the latest version of cargo-llvm-cov, correct?

Correct, the way to circumvent that is documented here:
https://github.com/taiki-e/install-action#example-workflow

@Alexhuszagh Alexhuszagh added meta issues/PRs related to the maintenance of the crate. no changelog A valid PR without changelog (no-changelog) labels Oct 2, 2022
@Alexhuszagh
Copy link
Contributor

We might want to lock it to a specific version of cargo-llvm-cov then just in case, since breaking versions changes might break our CI. tool: cargo-llvm-cov@0.5 so we only match minor versions of 0.5 might be a good idea here.

@Emilgardis Emilgardis changed the title use new report subcommand lock and fix cargo llvm-cov Oct 2, 2022
@bors
Copy link
Contributor

bors bot commented Oct 2, 2022

try

Build failed:

@Alexhuszagh
Copy link
Contributor

try

Build failed:

* [conclusion](https://github.com/cross-rs/cross/actions/runs/3169232460/jobs/5161096346)

It worked, it just seems --none will always fail due to an empty matrix.

@Emilgardis
Copy link
Member Author

It worked, it just seems --none will always fail due to an empty matrix.

should be easy to fix by inspecting the needs, will fix eventually

@Alexhuszagh
Copy link
Contributor

My mistake: apparently install-action doesn't follow Github Actions version syntax, it requires an exact version for getting the binary and doesn't match based on the semver. It's probably easier to just remove the version on cargo-llvm-cov and fix it later if we need to:

https://github.com/cross-rs/cross/actions/runs/3169293623/jobs/5161102311#step:4:31

@Emilgardis Emilgardis changed the title lock and fix cargo llvm-cov fix cargo llvm-cov ro use new report subcommand Oct 2, 2022
@Emilgardis Emilgardis changed the title fix cargo llvm-cov ro use new report subcommand fix cargo llvm-cov to use new report subcommand Oct 2, 2022
Copy link
Contributor

@Alexhuszagh Alexhuszagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just squash the commit history and merge when ready

also remove false comment
@Emilgardis
Copy link
Member Author

bors r=Alexhuszagh

@bors
Copy link
Contributor

bors bot commented Oct 2, 2022

Build succeeded:

@bors bors bot merged commit ff1ccfb into cross-rs:main Oct 2, 2022
@Emilgardis Emilgardis deleted the cov-fix branch October 2, 2022 18:34
@Emilgardis Emilgardis added this to the v0.3.0 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta issues/PRs related to the maintenance of the crate. no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants