Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo-spellcheck #423

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Add cargo-spellcheck #423

merged 3 commits into from
Mar 27, 2024

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Mar 26, 2024

@jayvdb
Copy link
Contributor Author

jayvdb commented Mar 27, 2024

@taiki-e, this requires GLIBC_2.34 and GLIBCXX_3.4.29, not available on older Linux.

I don't see a mechanism to indicate that a binary doesnt support older Linux. I'm happy to add something like that so that the CI can skip ones where it isnt supported. Sounds like a fairly large chunk of work though.

@jayvdb jayvdb mentioned this pull request Mar 27, 2024
@taiki-e
Copy link
Owner

taiki-e commented Mar 27, 2024

I don't see a mechanism to indicate that a binary doesnt support older Linux.

Please update one of the *_incompat arrays in tools/ci/tool-list.sh:

https://github.com/taiki-e/install-action/blob/main/DEVELOPMENT.md#troubleshooting

If CI fails only for containers using older versions of glibc or musl, you may need to add the tool name to one of the *_incompat arrays in tools/ci/tool-list.sh.

@jayvdb jayvdb marked this pull request as ready for review March 27, 2024 07:11
README.md Outdated Show resolved Hide resolved
Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@taiki-e taiki-e merged commit e52d622 into taiki-e:main Mar 27, 2024
26 checks passed
@jayvdb jayvdb deleted the cargo-spellcheck branch June 9, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants